-
Notifications
You must be signed in to change notification settings - Fork 173
feat: managed connection inclusion #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: managed connection inclusion #1242
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1242 +/- ##
==========================================
+ Coverage 80.37% 80.41% +0.04%
==========================================
Files 146 146
Lines 5777 5800 +23
Branches 1177 1185 +8
==========================================
+ Hits 4643 4664 +21
- Misses 645 646 +1
- Partials 489 490 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please mark it ready to review once the unit tests pass |
kushalshit27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please point to where we are adding the validation restriction when AUTH0_INCLUDED_CONNECTIONS and AUTH0_EXCLUDED_CONNECTIONS together?
…and AUTH0_EXCLUDED_CONNECTIONS
kushalshit27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current code changes are not working. Please add instructions on how to test, ensuring that the changes are thoroughly tested before moving to 'PR ready to review'.
- Adjusted logic to ensure 'enterprise-saml' is not marked for deletion when not in the include list. - Modified tests to reflect that 'google-oauth2' should not be deleted if it's not in the include list. - Updated behavior to only delete managed connections when assets are empty, preserving unmanaged ones. - Ensured that unmanaged connections are ignored during updates, preventing unintended deletions.
🔧 Changes
This PR introduces the
AUTH0_INCLUDED_CONNECTIONSconfiguration option to the Auth0 Deploy CLI. This allows for a "managed-only" approach to connection management, which is essential for environments where self-service or dynamic connections exist alongside managed infrastructure.Key Improvements:
exportandimport.JSON Format
Environment Variable
export AUTH0_INCLUDED_CONNECTIONS='["github","google-oauth2"]'📚 References
Closes #1163
Enterprise Connections
🔬 Testing
Unit test added
E2E added
📝 Checklist